Comments you submit will be routed for moderation. If you have an account, please log in first.
Modify

Ticket #405 (closed defect: fixed)

Opened 21 months ago

Last modified 20 months ago

scan_code can call all.extend when all is None

Reported by: anonymous Owned by: matysek
Priority: high Milestone: PyInstaller 1.5.2
Component: PyInstaller Version: 1.5.1
Severity: normal Keywords: scan_code, mf.py
Cc:

Description

The scan_code function in mf.py has a bug that allows this line to be executed when all is None:

all.extend(all_nested)

This is line 960 in v.1.5.1.

The bug is still present in the trunc as of the date this ticket was created (2011/08/26).

When hit this bombs out the PyInstaller? run so I am giving it a high priority.

Attachments

Change History

comment:1 Changed 21 months ago by matysek

How can be this bug reproduced? Any code example?

comment:2 Changed 21 months ago by anonymous

[OP here] It happened with one of our (large) projects but not another: don't know what in specific is triggering it. But it is pretty clear that there is a code path where all is None when it gets to the line that calls all.extend. My patch is simply this line before the all.extend line:

if all is None: all = [] #Ticket405 Patch

comment:3 Changed 20 months ago by htgoebel

fixed in #1604. Please back-port to 1.5 branch

comment:4 Changed 20 months ago by matysek

  • Status changed from new to assigned

comment:5 Changed 20 months ago by matysek

  • Status changed from assigned to closed
  • Resolution set to fixed

backported in r1647.

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.